Skip to content

Update broken links #13000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Update broken links #13000

merged 1 commit into from
Feb 9, 2020

Conversation

elvisciotti
Copy link
Contributor

Links were previously pointing to inexistent master branch and returning 404

Links were previously pointing to inexistent master branch and returning 404
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.. _decorate: https://en.wikipedia.org/wiki/Decorator_pattern
.. _RewriteRule shipped with the Symfony Standard Edition: https://github.com/symfony/symfony-standard/blob/master/web/.htaccess
.. _RewriteRule shipped with the Symfony Standard Edition: https://github.com/symfony/symfony-standard/blob/3.4
/web/.htaccess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be on a new line to fix the syntax (and the CI).

wouterj added a commit that referenced this pull request Feb 9, 2020
This PR was merged into the 3.4 branch.

Discussion
----------

Update broken links

Links were previously pointing to inexistent master branch and returning 404

Commits
-------

4030157 Update broken links
wouterj added a commit that referenced this pull request Feb 9, 2020
@wouterj wouterj merged commit 4030157 into symfony:3.4 Feb 9, 2020
@wouterj
Copy link
Member

wouterj commented Feb 9, 2020

Thanks @elvisciotti for submitting a fix for these broken links! I fixed the wrongly inserted newline in ea93e70

And whooohoo, congratz on making the 13000th ticket in this repository! 🎉

wouterj added a commit to wouterj/symfony-docs that referenced this pull request Feb 9, 2020
* 3.4:
  [symfony#13000] Fixed newline
  [symfony#12722] Added filename comment to avoid confusion
  Update micro_kernel_trait.rst
  Update broken links
wouterj added a commit to wouterj/symfony-docs that referenced this pull request Feb 9, 2020
* 4.4:
  [symfony#13000] Fixed newline
  Update testing.rst
  [symfony#12722] Added filename comment to avoid confusion
  Update micro_kernel_trait.rst
  Update broken links
wouterj added a commit to wouterj/symfony-docs that referenced this pull request Feb 9, 2020
* 5.0:
  [symfony#13000] Fixed newline
  Update testing.rst
  [symfony#12722] Added filename comment to avoid confusion
  Update micro_kernel_trait.rst
  Update link for (No|Admin)Recipient
  Typo
  Update broken links
@elvisciotti
Copy link
Contributor Author

And whooohoo, congratz on making the 13000th ticket in this repository! 🎉

thanks, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants